Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sveltekit): update more current docs to latest SvelteKitAuth API and finish example app migration to latest API #10191

Merged
merged 6 commits into from
Mar 2, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Mar 2, 2024

☕️ Reasoning

  1. Updates sveltekit example app to use the new SignOut button submitButton slot now that its shipped
  2. Cleanup @auth/sveltekit jsdoc doc regarding "per-path" authentication + authorization using the new sveltekit API
  3. Update current SvelteKitAuth docs regarding new SignIn / SignOut comopnents for server-side and the @auth/sveltekit/client exports signIn / signOut methods for cleint-side actions

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: 10187

📌 Resources

@ndom91 ndom91 requested a review from ThangHuuVu as a code owner March 2, 2024 16:10
Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 4:54pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2024 4:54pm
nextra-docs ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2024 4:54pm

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 39.31%. Comparing base (5136ca4) to head (4c90264).
Report is 3 commits behind head on main.

Files Patch % Lines
packages/frameworks-sveltekit/src/lib/index.ts 0.00% 86 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10191      +/-   ##
==========================================
- Coverage   39.39%   39.31%   -0.08%     
==========================================
  Files         171      171              
  Lines       27181    27236      +55     
  Branches     1154     1157       +3     
==========================================
  Hits        10708    10708              
- Misses      16473    16528      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title docs(sveltekit): example app use new components slot and cleanup sveltekit docs docs(sveltekit): update more current docs to latest SvelteKitAuth API and finish example app migration to latest API Mar 2, 2024
@ndom91 ndom91 changed the title docs(sveltekit): update more current docs to latest SvelteKitAuth API and finish example app migration to latest API chore(sveltekit): update more current docs to latest SvelteKitAuth API and finish example app migration to latest API Mar 2, 2024
@ndom91 ndom91 merged commit 8cc2a0f into main Mar 2, 2024
12 of 15 checks passed
@ndom91 ndom91 deleted the ndom91/update-sveltekit-examples branch March 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per Path authorization example doesn't work since adding signIn and signOut to SvelteKitAuth()
1 participant